Skip to content

[PWGCF] Fix histogram filling in femto framework - #18691

Merged
ariedel-cern merged 11 commits into
AliceO2Group:masterfrom
ariedel-cern:master
Nov 11, 2026
Merged

[PWGCF] Fix histogram filling in femto framework#18691
ariedel-cern merged 11 commits into
AliceO2Group:masterfrom
ariedel-cern:master

Conversation

@ariedel-cern

@ariedel-cern ariedel-cern commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator
  • Fill same event particle histograms only if the particle pair survives all pair cuts
  • Add SE/ME split for collision histograms, also fill SE histograms only if a valid pair is found
  • Add kstar axis to multidimentional histograms in dNdeta tasks

@github-actions github-actions Bot added the pwgcf label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@ariedel-cern
ariedel-cern marked this pull request as ready for review November 11, 2026 12:48
@ariedel-cern ariedel-cern changed the title [PWGCF] Fix histogrammin in femto framework [PWGCF] Fix histogram filling in femto framework Nov 11, 2026
@ariedel-cern
ariedel-cern enabled auto-merge (squash) November 11, 2026 13:23
alibuild
alibuild previously approved these changes Nov 11, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern
ariedel-cern marked this pull request as draft November 11, 2026 13:51
auto-merge was automatically disabled November 11, 2026 13:51

Pull request was converted to draft

@alibuild

alibuild commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 5f49ba7 at 2026-11-11 15:01:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/pairProcessHelpers.h:774:29: error: unused parameter 'ColHistManager' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/pairProcessHelpers.h:774:29: error: unused parameter 'ColHistManager' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/pairProcessHelpers.h:774:29: error: unused parameter 'ColHistManager' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/pairProcessHelpers.h:774:29: error: unused parameter 'ColHistManager' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/pairProcessHelpers.h:774:29: error: unused parameter 'ColHistManager' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Femto/Core/pairProcessHelpers.h:774:29: error: unused parameter 'ColHistManager' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@ariedel-cern
ariedel-cern marked this pull request as ready for review November 11, 2026 14:46
@ariedel-cern
ariedel-cern marked this pull request as draft November 11, 2026 14:47
@ariedel-cern
ariedel-cern marked this pull request as ready for review November 11, 2026 17:35
@ariedel-cern
ariedel-cern enabled auto-merge (squash) November 11, 2026 18:55
alibuild
alibuild approved these changes Nov 11, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern
ariedel-cern merged commit f6befa1 into AliceO2Group:master Nov 11, 2026
13 of 15 checks passed
@alibuild

alibuild commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a450c73 at 2026-11-11 23:00:

## sw/BUILD/O2-latest/log
2026-11-11T20:55:21.390+0100 [29105:129644119943232] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:21.697+0100 [28657:135258860509248] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:22.891+0100 [29574:134061707356224] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:22.989+0100 [29655:130395941505088] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:21.697+0100 [29832:123721836972096] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:21.698+0100 [29832:123721836972096] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:23.230+0100 [29832:123721836972096] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:22.020+0100 [29858:128773934078016] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:22.020+0100 [29858:128773934078016] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:23.536+0100 [29858:128773934078016] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:23.727+0100 [29000:132691330181184] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:23.970+0100 [25741:127079260268608] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:24.025+0100 [29408:137214251104320] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:24.246+0100 [29149:138341586323520] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:23.329+0100 [29893:127541035931712] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:23.329+0100 [29893:127541035931712] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:24.936+0100 [29893:127541035931712] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:23.878+0100 [29952:131148307707968] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:23.878+0100 [29952:131148307707968] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:23.626+0100 [29923:123522938492992] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:23.626+0100 [29923:123522938492992] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:24.067+0100 [29980:125379685685312] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:24.067+0100 [29980:125379685685312] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:20.467+0100 [29680:132673676765248] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:20.468+0100 [29680:132673676765248] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:20.736+0100 [29727:132147434543168] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:20.736+0100 [29727:132147434543168] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:21.243+0100 [29779:134557123962944] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:21.243+0100 [29779:134557123962944] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:21.047+0100 [29756:124358869350464] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:21.047+0100 [29756:124358869350464] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-11-11T20:55:20.873+0100 [29706:130364082092096] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-11-11T20:55:20.873+0100 [29706:130364082092096] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/95560b771aee337b7843359cfb3c2a2c9a203627/O2Physics-code-check/errors.txt
[0 more errors; see full log]

Full log here.

@ariedel-cern

ariedel-cern commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

code-check error fixed in #18703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@dimihayl dimihayl Awaiting requested review from dimihayl dimihayl is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice dsarkaralice is a code owner
@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner

Assignees

No one assigned

Labels

datamodel pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ariedel-cern @alibuild